Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

ci: fix CircleCI carthage timeout #260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jul 27, 2022

New Pull Request Checklist

Issue Description

Related issue: parse-community/Parse-SDK-iOS-OSX#1656

Approach

Increase timeout.

TODOs before merging

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 27, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member Author

mtrezza commented Jul 28, 2022

@drdaz Strangely, here the timeout increase did not help, Carthage keep failing after ~16mins. Any idea?

@drdaz
Copy link
Member

drdaz commented Aug 2, 2022

@mtrezza Not without seeing the test logs I'm afraid. It should be possible to run the target enabling SSH access, then you should be able to see how it's failing. The location of the logs is provided in the test failure console output.

@drdaz
Copy link
Member

drdaz commented Aug 2, 2022

Oh now I see it 😅

Carthage seems to be importing v6.x of the Facebook SDK. The main repo uses 11.x (which is also pretty behind the times), and contains breaking changes.

@mtrezza
Copy link
Member Author

mtrezza commented Aug 3, 2022

Got it, do you think upgrading the FB SDK would be a time consuming PR?

@drdaz
Copy link
Member

drdaz commented Aug 5, 2022

I feel like maybe another PR would be overkill. I'm pretty sure if you run carthage update on here and commit the changes to Cartfile.resolved (not all the stuff it checks out and builds), it'll work.

I tried to push those changes to this branch, but I'm getting an authentication error. Not sure if that's on my end or if I don't have push-powers here.

@mtrezza
Copy link
Member Author

mtrezza commented Aug 5, 2022

or if I don't have push-powers here

I think only the author and repo maintainers can push to a PR as the settings currently are.

@mtrezza
Copy link
Member Author

mtrezza commented Aug 5, 2022

carthage update failed for me on arm64 with:

Building universal frameworks with common architectures is not possible. The device and simulator slices for "Bolts" both build for: arm64
Rebuild with --use-xcframeworks to create an xcframework bundle instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants