-
-
Notifications
You must be signed in to change notification settings - Fork 132
ci: fix CircleCI carthage timeout #260
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
@drdaz Strangely, here the timeout increase did not help, Carthage keep failing after ~16mins. Any idea? |
@mtrezza Not without seeing the test logs I'm afraid. It should be possible to run the target enabling SSH access, then you should be able to see how it's failing. The location of the logs is provided in the test failure console output. |
Oh now I see it 😅 Carthage seems to be importing v6.x of the Facebook SDK. The main repo uses 11.x (which is also pretty behind the times), and contains breaking changes. |
Got it, do you think upgrading the FB SDK would be a time consuming PR? |
I feel like maybe another PR would be overkill. I'm pretty sure if you run I tried to push those changes to this branch, but I'm getting an authentication error. Not sure if that's on my end or if I don't have push-powers here. |
I think only the author and repo maintainers can push to a PR as the settings currently are. |
|
New Pull Request Checklist
Issue Description
Related issue: parse-community/Parse-SDK-iOS-OSX#1656
Approach
Increase timeout.
TODOs before merging
n/a