[Proposal] Unified Client interface #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mcgowan
reviewed
Feb 14, 2017
| class CustomError extends VError { | ||
| constructor() { | ||
| super(...arguments); | ||
| this.name = this.constructor.name; |
There was a problem hiding this comment.
Does this work without babel transpiling? anything in the JS spec that says a constructor name equals the name of the subclass?
| @@ -0,0 +1,11 @@ | |||
| export default class Base { | |||
There was a problem hiding this comment.
perhaps we call it BaseModel to be more descriptive?
suda
commented
Feb 14, 2017
| let exception = new NotImplementedError(); | ||
| expect(NotImplementedError.matches(exception)).to.be.true; | ||
| }) | ||
| }); |
There was a problem hiding this comment.
TODO: Add tests for error chaining
suda
force-pushed
the
feature/build-targets
branch
from
22f578d
to
65de0db
Compare
|
@busticated this is the stateful |
|
i moved this back into "draft" state to calm the reminders. i don't see us merging this anytime soon if only b/c it's so out of date but it's a good reference so i'm fine w/ leaving it open as a draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds build targets support to Client class and drafts a proposal for unified endpoint/resource handling.
Notes about some decisions:
undefinedvalues but still be documentedbuild_targetendpoint is an interesting example because it groups targets by version name but we want to access each build target separately (which would be possible in endpoint V2). So we're normalizing the data and providing the interface which will remain constant even after switching the backing endpointErrorbuilding/handling pattern that combines our three implementations mentioned in the ClubHouse story