Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Commit

Permalink
Fix build for Minecraft 1.18.2
Browse files Browse the repository at this point in the history
One of the two 'renderSky' signatures of the 'WorldRenderer' class changed
and therefore the mixin failed to apply. As the mapping also have been
updated now, just building for 1.18.2 fixes the issue, but also makes it
incompatible with previous versions.
  • Loading branch information
pascallj committed May 21, 2022
1 parent d5af6b7 commit 77c54ac
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
10 changes: 5 additions & 5 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ org.gradle.jvmargs=-Xmx1G

# Fabric Properties
# check these on https://fabricmc.net/develop
minecraft_version=1.18.1
yarn_mappings=1.18.1+build.22
loader_version=0.13.2
minecraft_version=1.18.2
yarn_mappings=1.18.2+build.3
loader_version=0.14.6
modmenu_version=3.0.1

# Mod Properties
mod_version = 3.1.0
mod_version = 3.1.1
archives_base_name = mineshot-revived
maven_group = com.example

# Dependencies
fabric_version=0.46.4+1.18
fabric_version=0.53.0+1.18.2
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,20 @@ protected void init() {
this.addSelectableChild(this.optionsListWidget);
this.addDrawableChild(new ButtonWidget(this.width / 2 - 100, this.height - 27, 200, 20,
ScreenTexts.DONE, (buttonWidget) -> {
onClose();
close();
}));
}

@Override
public void onClose() {
public void close() {
this.properties.set("captureWidth", captureWidth.getText());
this.properties.set("captureHeight", captureHeight.getText());
this.properties.set("notifyDev", notifyDev.isChecked() ? "true" : "false");
this.properties.set("notifyIncompatible", notifyIncompatible.isChecked() ? "true" : "false");
this.properties.set("xRotation", xRotation.getText());
this.properties.set("yRotation", yRotation.getText());
this.properties.storeProperties();
super.onClose();
super.close();
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions versions.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"latest": "3.1.0",
"latest": "3.1.1",
"dev": "4.0.0-beta.1",
"1.19.x": {
"latest": "4.0.0-beta.1",
"dev": "4.0.0-beta.1"
},
"1.18.x": {
"latest": "3.1.0",
"dev": "3.1.0"
"latest": "3.1.1",
"dev": "3.1.1"
},
"1.17": {
"latest": "2.0.0",
Expand Down

0 comments on commit 77c54ac

Please sign in to comment.