Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: v2 metadata URL #699

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,17 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.12"

- name: Install pipenv
run: pip3 install pipenv
- name: Install poetry
run: |
pip3 install pipx
pipx ensurepath
pipx install poetry

- name: Generate requirements.txt
working-directory: ./api
run: pipenv requirements --dev > requirements.txt
run: poetry export -f requirements.txt -o requirements.txt --with dev

- name: Install API dependencies
working-directory: ./api
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/test_generic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,17 @@ jobs:
fetch-depth: 0
- uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.12"

- name: Install pipenv
run: pip3 install pipenv
- name: Install poetry
run: |
pip3 install pipx
pipx ensurepath
pipx install poetry

- name: Generate requirements.txt
working-directory: ./api
run: pipenv requirements --dev > requirements.txt
run: poetry export -f requirements.txt -o requirements.txt --with dev

- name: Install API dependencies
working-directory: ./api
Expand Down
16 changes: 8 additions & 8 deletions api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# https://pipenv.pypa.io/en/latest/basics/#pipenv-and-docker-containers
FROM --platform=linux/amd64 docker.io/python:3.11 AS base
FROM --platform=linux/amd64 docker.io/python:3.12 AS base

RUN apt update && \
apt install -y python3-dev libpq-dev
Expand All @@ -11,12 +11,15 @@ RUN apt update && \
FROM base AS builder

RUN pip install --upgrade pip && \
pip install --user pipenv
pip install --user pipx && \
/root/.local/bin/pipx ensurepath && \
/root/.local/bin/pipx install poetry

# Tell pipenv to create venv in the current directory
ENV PIPENV_VENV_IN_PROJECT=1
ENV POETRY_VIRTUALENVS_IN_PROJECT=1

ADD Pipfile.lock /usr/src/
ADD poetry.lock /usr/src/
ADD pyproject.toml /usr/src/

WORKDIR /usr/src

Expand All @@ -26,10 +29,7 @@ WORKDIR /usr/src
# you need to have pycurl build dependencies libcurl4-gnutls-dev and libcurl3-gnutls
# In the runtime container you need only libcurl3-gnutls

# RUN apt install -y libcurl3-gnutls libcurl4-gnutls-dev
# RUN /root/.local/bin/pipenv lock

RUN /root/.local/bin/pipenv sync
RUN /root/.local/bin/poetry install
RUN /usr/src/.venv/bin/python -c "import django; print(django.__version__)"


Expand Down
10 changes: 5 additions & 5 deletions api/Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ web3 = "*"
siwe = "*"
psycopg2-binary = "*"
djangorestframework-api-key = "==2.*"
celery = {extras = ["redis"], version = "*"}
requests = "*"
social-auth-app-django = "*"
dag-cbor = "*"
Expand All @@ -36,17 +35,16 @@ django-debug-toolbar = "*"
django-filter = "*"
boto3 = "*"
tqdm = "*"
gql = "*"
requests-toolbelt = "*"
pyarrow = "*"
pynacl = "*"
faker = "*"
python-jose = "*"
uvarint = "*"
django-ace = "*"
async-timeout = "*"
aiohttp = "*"
freezegun = "*"
poetry = "*"
pipenv-poetry-migrate = "*"

[dev-packages]
black = "*"
Expand All @@ -59,6 +57,8 @@ pytest-bdd = "*"
pytest-mock = "*"
django-stubs = "*"
pandas = "*"
faker = "*"
freezegun = "*"

[requires]
python_version = "3.11"
python_version = "3.12"
4,073 changes: 2,410 additions & 1,663 deletions api/Pipfile.lock

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion api/account/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def submit_signed_challenge(request, payload: SiweVerifySubmit):
raise InvalidNonceException()

try:
message: SiweMessage = SiweMessage(payload.message)
message: SiweMessage = SiweMessage(**payload.message)
verifyParams = {
"signature": payload.signature,
# See note in /nonce function above
Expand Down
6 changes: 3 additions & 3 deletions api/account/test/test_account.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_nonce(self):

def test_create_account_with_SIWE(self):
"""Test creation of an account wit SIWE"""
siwe = SiweMessage(self.siwe_data_pay)
siwe = SiweMessage(**self.siwe_data_pay)
data_to_sign = siwe.prepare_message()

private_key = account.key
Expand All @@ -86,7 +86,7 @@ def test_create_account_with_SIWE(self):
self.assertTrue("access" in data)

def test_account_address_is_lower_case(self):
siwe = SiweMessage(self.siwe_data_pay)
siwe = SiweMessage(**self.siwe_data_pay)
data_to_sign = siwe.prepare_message()

private_key = account.key
Expand All @@ -111,7 +111,7 @@ def test_account_address_is_lower_case(self):
self.assertEqual(created_account.address, account.address.lower())

def test_create_account_with_www_domain(self):
siwe = SiweMessage(self.siwe_data_pay)
siwe = SiweMessage(**self.siwe_data_pay)
data_to_sign = siwe.prepare_message()
data_to_sign = siwe.prepare_message()

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import json
from decimal import Decimal

import pytest
from django.conf import settings
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import json

import pytest
from django.conf import settings

from aws_lambdas.scorer_api_passport.v1 import (
score_GET,
score_POST,
stamp_GET,
weights_GET,
)
from ceramic_cache.models import CeramicCache
from django.conf import settings
from registry.models import Passport, Score
from registry.utils import get_utc_time

Expand All @@ -33,7 +34,7 @@ def test_score_get(
status=Score.Status.DONE,
last_score_timestamp=get_utc_time(),
error=None,
stamp_scores=[],
stamp_scores={},
evidence={
"rawScore": 10,
"type": "binary",
Expand Down
13 changes: 8 additions & 5 deletions api/aws_lambdas/submit_passport/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

# https://pipenv.pypa.io/en/latest/basics/#pipenv-and-docker-containers
FROM --platform=linux/amd64 public.ecr.aws/lambda/python:3.11 AS base
FROM --platform=linux/amd64 public.ecr.aws/lambda/python:3.12 AS base


#########################################################
Expand All @@ -9,16 +9,19 @@ FROM --platform=linux/amd64 public.ecr.aws/lambda/python:3.11 AS base
FROM base AS builder

RUN pip install --upgrade pip && \
pip install pipenv
pip install --user pipx && \
/root/.local/bin/pipx ensurepath && \
/root/.local/bin/pipx install poetry

# Tell pipenv to create venv in the current directory
ENV PIPENV_VENV_IN_PROJECT=1
ENV POETRY_VIRTUALENVS_IN_PROJECT=1

ADD Pipfile.lock /usr/src/
ADD poetry.lock /usr/src/
ADD pyproject.toml /usr/src/

WORKDIR /usr/src

RUN pipenv requirements > requirements.txt
RUN /root/.local/bin/poetry export -f requirements.txt -o requirements.txt

#########################################################
# Runtime
Expand Down
44 changes: 41 additions & 3 deletions api/aws_lambdas/submit_passport/submit_passport.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,21 @@
This module provides a handler to manage API requests in AWS Lambda.
"""

import logging

from asgiref.sync import async_to_sync
from django.db import close_old_connections

from aws_lambdas.exceptions import InvalidRequest
from aws_lambdas.utils import (
with_api_request_exception_handling,
)
from registry.api.v1 import (
SubmitPassportPayload,
ahandle_submit_passport,
)
from django.db import close_old_connections

# Now this script or any imported module can use any part of Django it needs.
# from myapp import models
logger = logging.getLogger(__name__)


@with_api_request_exception_handling
Expand All @@ -32,3 +35,38 @@ def _handler(event, _context, request, user_account, body):
def handler(*args, **kwargs):
close_old_connections()
return _handler(*args, **kwargs)


@with_api_request_exception_handling
def _handler_get_score(event, _context, request, user_account, body):
path = event.get("path", "").split("/")

if len(path) != 6:
raise InvalidRequest(f"Invalid path: '{path}'")

scorer_id = path[3]
address = path[5]

logger.info(f"path: '%s', scorer_id: '%s', address: %s", path, scorer_id, address)

# unquote(event.get("queryStringParameters", {}).get("model_list", ""))

score = async_to_sync(ahandle_submit_passport)(
SubmitPassportPayload(
scorer_id=scorer_id,
address=address,
),
user_account,
)

return score


def handler_get_score(*args, **kwargs):
"""
This handles the new GET request for the score, that also implies doing the same score
calculation as on the previous POST `submit-passport` request
"""

close_old_connections()
return _handler_get_score(*args, **kwargs)
Loading
Loading