Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses edge case raised in #488 when t0 == t1 and
saveat.ts
is notNone
. Additionally ifsaveat.t0
isTrue
then those values were not updated either, which should be addressed by this PR. I've additionally included a test for this case.WRT the implementation: while a loop is not very nice since everything could in principle be done in parallel, the below did not work for the
ts
part due to dynamic slicing errors. Let me know if there is a nicer workaround I could try :)