Proof-of-concept Twig 2.x integration #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidfunk
changed the title
|
Thanks @squidfunk!! Out of curiosity, have you guys tried using Twig embeds with this implementation? I'm still experimenting a bit with this locally which, for the most part, works perfectly, however I've noticed that something relating to embeds (but not extends or includes) appears to throw a Twig error relating to a string template not being found... Have you guys encountered any other problems or strange behavior with this upgrade to Twig v2? |
|
To be honest, we switched to patternlab-node and now use twig.js for rendering. The PHP version is so flawed and so slow that we had no choice. twig.js is not a perfect solution, but it works and we can even render twig templates in the browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a client project which has Symfony 3 as a dependency I want to be able to use Patternlab with Twig 2.x, which is the default version bundled with the framework. For this reason I forked the project and created a proof-of-concept working version which might be a good starting point for supporting Twig 2.x. This is the corresponding PR.
I think it would be of great use for many developers, but as there are no tests, I'm not a 100% sure I got everything right. Feel free to comment and see this PR as a work-in-progress.