Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Adding new hardware from FE commissioning #175

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

WIP: Adding new hardware from FE commissioning #175

wants to merge 3 commits into from

Conversation

imohacsi
Copy link
Contributor

No description provided.

@imohacsi
Copy link
Contributor Author

WIP == WORK IN PROGRESS
DO NOT MERGE!!!

@imohacsi imohacsi changed the title Adding new hardware from FE commissioning WIP: Adding new hardware from FE commissioning Nov 13, 2022
@imohacsi imohacsi marked this pull request as draft November 13, 2022 17:10
kivel
kivel requested changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@kivel kivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the comment<->setting thing is tedious, but it helps mid/long term.
About the newline, this might not be an issue, as depending on the editor you're using github is not showing them, but iocsh will still work w/o issues.

hardware/Encoders/ecmcEL5042-Encoder-ch12-Renishaw_RL32BVS001C30V.cmd Outdated Show resolved Hide resolved
hardware/Encoders/ecmcEP5001-Encoder-Posital-UCD-S101B-1216-HES0-PRQ.cmd Show resolved Hide resolved
hardware/Motors/ecmcEL7041-Motor-OrientalMotor-PK268MD-28B.cmd Show resolved Hide resolved
hardware/Motors/ecmcEP7041-Motor-OrientalMotor-PKP299D45B.cmd Outdated Show resolved Hide resolved
hardware/Motors/ecmcEP7041-Motor-OrientalMotor-PKP299D45B.cmd Show resolved Hide resolved
@kivel
Copy link
Collaborator

kivel commented Nov 6, 2023 •
edited
Loading

@imohacsi is this PR still relevant?
I apparently overlooked your fixes, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kivel kivel kivel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imohacsi @kivel