Document commands to run in dev docker containers (rebased) #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Previous PR](#215) - Improve documentation of the commands to run in each container - Some minor fixes to docker-compose to support recent docker versions ## Squashed commits - Refactor fe dev Dockerfile Remove nginx stuff; if this is needed, use the production image - Document commands to run in dev containers - Fix be_next command in README - Document BE env vars - Fix docker-compose Recent docker versions don't support depends_on in base profiles used with extends
minottic
reviewed
Jun 5, 2024
Also a small update to readme (use of `docker-compose` is deprecated - revert 'depends_on' change. This was a [docker bug in 2.24](docker/compose#11544) - Remove unneeded comments
|
I reverted the docker_compose changes, so this PR is now purely README changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Previous PR
Squashed commits