Use html sanitized text for attachments

paulscherrerinstitute · Apr 18, 2024 · fdfd91e · fdfd91e
1 parent 90fea3a
commit fdfd91e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/sci-log-db/src/__tests__/unit/service.export-snippet.unit.ts b/sci-log-db/src/__tests__/unit/service.export-snippet.unit.ts
@@ -331,6 +331,16 @@ describe('Export service unit', function (this: Suite) {
         [['someFile.pdf', 'accessHash2']],
       ],
     },
+    {
+      input: [
+        {files: [{fileHash: 'hash123', accessHash: 'accessHash2'}]},
+        '<div class="fileLink" href="file:hash123">someFile_>_.pdf</div>',
+      ],
+      expected: [
+        '<filelink>attachments/someFile_&gt;_.pdf</filelink>',
+        [['someFile_>_.pdf', 'accessHash2']],
+      ],
+    },
   ].forEach((t, i) => {
     it(`attachment ${i}`, async () => {
       const element = textContentToHTML({textcontent: t.input[1]} as Paragraph);

diff --git a/sci-log-db/src/services/export-snippets.service.ts b/sci-log-db/src/services/export-snippets.service.ts
@@ -233,7 +233,7 @@ export class ExportService {
         `.fileLink[href='file:${fileSnippet.fileHash}']`,
       );
       if (!fileLinkElement) return;
-      const attachment = fileLinkElement.innerHTML;
+      const attachment = fileLinkElement.textContent ?? '';
       const attachmentElement = this.document.createElement('fileLink');
       attachmentElement.innerHTML = `${this.attachmentsFolder}/${fileLinkElement.innerHTML}`;
       fileLinkElement.replaceWith(attachmentElement);