[FIX] wrong value set for the created frame width on first render #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recompute the 'selectorWidth' value inside the 'buildSliderFrame' method:
set inside the constructor and the computed value in the browser
If you want to know what I'm talking about, please see this pen, actually it's a pen from the creator of this lib ^^:
This PR aims to fix this issue.
Hey there @pawelgrzybek, first, thanks for your carousel, it's pretty neat and clean :)
Do you think you could take a look at my PR and see if it's mergeable?
I am currently using siema for a project at work, and I encounter this problem quite often.
See this video to see what it looks like: https://streamable.com/dpb5a