Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply dark mode in win32 api to rufus #2510

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

memoarfaa
Copy link
Contributor

@memoarfaa memoarfaa commented Jun 24, 2024

This is an idea about apply DarkMode to rufus it still in progress but if you welcome it, I will finish it fix #1453

2024-06-24_19-49-08.mp4

@memoarfaa memoarfaa changed the title Apply dark mode in win32 api to rufus fix #1453 Apply dark mode in win32 api to rufus Jun 24, 2024
@memoarfaa memoarfaa marked this pull request as ready for review June 24, 2024 17:35
@pbatard
Copy link
Owner

pbatard commented Jun 24, 2024

Well, it's still going to be some time before I switch Rufus UI to XAML Islands and (hopefully) get Dark Mode automatically, so, if you want to invest your time to add Dark Mode to the current GDI-based UI, and considering that I do expect to be pestered by people who want Dark Mode for quite a few more years, I definitely wouldn't mind having an intermediate solution for Rufus.

This means that, if you are willing to contribute one, I'm not going to shut you down, as long as it doesn't look like it's going to be too intrusive to the existing code, which, at first glance at your draft proposal, doesn't look like is it, and as long as you fix the MinGW build issues. So you are getting a thumbs up from me.

If it helps, I'm also going to attach the patch that I originally played with to produce my own version of dark themed Rufus, which produced the output you see below and that I posted in #1453 (Unlike you, I didn't get to sort the progress bar and backgrounds, but I did sort out the title bar, so maybe you'll find something useful, though I have to point out that this was a quick & dirty tryout and definitely not production-ready code):

Image2

For the record, this patch is meant to be applied on top of commit 129aa64, which means it was designed circa Rufus 3.10, so, obviously, the code has changed a bit since then.

@memoarfaa memoarfaa marked this pull request as draft June 24, 2024 21:59
@pbatard pbatard force-pushed the master branch 3 times, most recently from ceee3e9 to d5302c0 Compare July 19, 2024 12:47
Copy link

@randompersononinternet69 randompersononinternet69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing to build MinGW version.

@Dhyfer1
Copy link

Dhyfer1 commented Oct 2, 2024

@memoarfaa Good job 👏, it's amazing that third parties can do something that the developer himself has not been able to do. There is already an issue asking for the dark theme for Rufus but the dev is not interested, too difficult for him, but thanks to you we see that it is possible without installing external themes. Keep moving forward with this 👍

@pbatard pbatard force-pushed the master branch 2 times, most recently from 28b105c to 98a42a2 Compare October 5, 2024 19:21
Repository owner deleted a comment from Ahmedcity Oct 29, 2024
Repository owner deleted a comment from JonnyTech Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark theme
4 participants