allow globs for denyImports and denyFiles
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 25a324d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
| Allow globs for `denyImports` and `denyFiles` | ||
|
|
||
| Using [micromatch][https://github.com/micromatch/micromatch] for pattern matching |
There was a problem hiding this comment.
Out of curiosity, why'd you go with this library?
There was a problem hiding this comment.
Vite uses fast-glob, and fast-glob uses micromatch. It's one of the reasons fast-glob is faster than glob.
There was a problem hiding this comment.
fast-globusesmicromatch
Ah nice, I was missing this context 👍
| @@ -25,7 +27,7 @@ export function validateId({ | |||
|
|
|||
| for (const pattern of patterns) { | |||
| if ( | |||
| (typeof pattern === "string" && id === pattern) || | |||
| (typeof pattern === "string" && isMatch(id, pattern)) || | |||
There was a problem hiding this comment.
Love how simple this change is!
markdalgleish
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.