-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow globs for denyImports
and denyFiles
#29
Conversation
🦋 Changeset detectedLatest commit: 25a324d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
Allow globs for `denyImports` and `denyFiles` | ||
|
||
Using [micromatch][https://github.com/micromatch/micromatch] for pattern matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why'd you go with this library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vite uses fast-glob
, and fast-glob
uses micromatch
. It's one of the reasons fast-glob
is faster than glob
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-glob
usesmicromatch
Ah nice, I was missing this context 👍
@@ -25,7 +27,7 @@ export function validateId({ | |||
|
|||
for (const pattern of patterns) { | |||
if ( | |||
(typeof pattern === "string" && id === pattern) || | |||
(typeof pattern === "string" && isMatch(id, pattern)) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love how simple this change is!
No description provided.