ami2 script for lcls-1 hutches #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
Oct 9, 2024
scripts/startami2
Outdated
| get_status(){ | ||
| grep ami2_ $STATUS_FILE | awk {'print $1"\t"$2"\t"$3'} | ||
| } | ||
| echo |
There was a problem hiding this comment.
Is this echo left here by accident, or does it do something?
|
Thanks for your comments Zach! Yes I noticed I did not have pre-commit installed on my checkout and was going to fix the syntax suggestions. |
|
One other tiny tiny thing- it'd be good to add this new script to the readme table |
|
Still need to figure out some issues with the mypy deamon for the second client to work smoothly... Let's hold on merging until I figure this out |
|
Ok, this is ready for review / merge! |
ZLLentz
reviewed
Nov 14, 2024
ZLLentz
reviewed
Nov 14, 2024
There was a problem hiding this comment.
I think the main thing missing from my point of view is including this script in the readme table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make a script to restart/stop ami2 and start more clients
Motivation and Context
Needed for smoother operation with ami2 in LCLS-I hutches
How Has This Been Tested?
With XPP DAQ and AMI
Where Has This Been Documented?
N/A