Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using epics7 env for rocky9 compatibility #223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KaushikMalapati
Copy link
Contributor

Description

motor-expert-screen was using epicsenv-3.14.12.sh, but the oldest version of epics base available on rocky9 is 7.0.2, so motor-expert-screen will use that environment from now on

I also had to update how :PN motors are opened, because originally they executed a file that tried to activate the epics 3.14 environment. Now I am directly opening the screen with edm and I added the path to EDMDATAFILES

Motivation and Context

https://jira.slac.stanford.edu/browse/ECS-6842

How Has This Been Tested?

Interactively

Where Has This Been Documented?

n/a

@ZLLentz
Copy link
Member

ZLLentz commented Nov 20, 2024

I agree with this conceptually and I agree with the implementation
Let me double-check a few screen loads before/after on a hutch machine to make sure there aren't any obvious regressions

@ZLLentz
Copy link
Member

ZLLentz commented Nov 20, 2024

This PR absolutely enables this script to be run from rocky9 hosts! Very good.

Here are the PV bases I'm planning to compare:

IMS: XPP:USR:MMS:01
PP: XPP:SB2:MMS:29
Newport: XPP:USR:MMN:01
AeroTech: XCS:SND:T1:Y1
SmarAct: XPP:MCS2:01:m1
Beckhoff (old): MFX:LJH:JET:X
Beckhoff (new): IM3L0:PPM:MMS

So far, the IMS was the exactly the same but the PP (old IMS) picked a slightly different screen (top is with the PR, bottom is before this PR):
image

I'll continue through the rest, it shouldn't take too long

@ZLLentz
Copy link
Member

ZLLentz commented Nov 20, 2024

Everything was the same except for these super old pulse picker screens which are now using a less readable variant

@KaushikMalapati
Copy link
Contributor Author

KaushikMalapati commented Nov 20, 2024

I will move the update EDMDATAFILES to use the old pcds_motionScreens directory. I assumed the newer version would just be better, but I guess not. Thanks for checking all this. Do you think there is anything else I should test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants