Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: run release notes script for v1.18.1 #361

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Apr 4, 2023

Description

Get release notes ready for the tag

Motivation and Context

I want to tag every package that I help maintain since we haven't done this at all in 2023.

How Has This Been Tested?

n/a

Where Has This Been Documented?

is docs

@ZLLentz ZLLentz requested review from klauer and tangkong April 4, 2023 19:11
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we've been ignoring the tests that fail here, or at least procrastinating on fixing them. This should be good to go probably.

@ZLLentz
Copy link
Member Author

ZLLentz commented Apr 4, 2023

You're right, looks like I've put it on the backburner. See #357

@ZLLentz
Copy link
Member Author

ZLLentz commented Apr 4, 2023

There's also an unrelated failure message I see:

psdm_qs_cli library unavailable

(pypi)

@ZLLentz
Copy link
Member Author

ZLLentz commented Apr 4, 2023

The weird pip failure was only in a workflow running on my fork, rather than the workflow running here 😕

@klauer
Copy link
Contributor

klauer commented Apr 4, 2023

Is the workaround just restricting our IPython version in pcds-env for now?

@ZLLentz
Copy link
Member Author

ZLLentz commented Apr 4, 2023

Yes, IPython is currently on the "do not update this basically ever" list due to past pain with unexpected breaks or behavior changes between minor releases.

@ZLLentz ZLLentz merged commit 7917557 into pcdshub:master Apr 4, 2023
@ZLLentz ZLLentz deleted the rel_v1.18.1 branch April 4, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants