Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: addressing the state input deadlock bug #198

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Sep 7, 2023

Description

When the user resets an error, bring the states input handler FB back to a known state.

Motivation and Context

Will close #197

In short: previously, we could get into a deadlocked state where the input FB would always keep bExecute high, which means the move FB would never be able to get a rising edge.

How Has This Been Tested?

  • Unit test that fails before and passes afterwards
  • Interactive testing with the example motion plc code

Where Has This Been Documented?

Detailed documentation in the unit test

Pre-merge checklist

  • Code works interactively
  • Test suite passes locally
  • Code contains descriptive comments
  • Libraries are set to Always Newest version (Library, *)
  • Committed with pre-commit or ran pre-commit run --all-files

@ZLLentz ZLLentz marked this pull request as ready for review September 8, 2023 20:47
Copy link

@tylerjohnson3208 tylerjohnson3208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tylerjohnson3208
Copy link

Whoops... logged in my personal account.

@ZLLentz ZLLentz merged commit 84f1b81 into pcdshub:master Sep 12, 2023
9 checks passed
@ZLLentz ZLLentz deleted the fix_input_deadlock branch September 12, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown Race Condition/State Machine Deadlock in States Motion
2 participants