BUG: reverse the in/out order in the in/out example fbs to match their enum #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ZLLentz
commented
Feb 2, 2024
| astPositionState[1] := stIn; | ||
| astPositionState[2] := stOut; | ||
| // Assemble the states array, matching the enum values (OUT is 1, IN is 2) | ||
| astPositionState[1] := stOut; |
There was a problem hiding this comment.
self-review thought before I leave today: this should probably look more like this:
astPositionState[E_EpicsInOut.OUT] := stOut
|
The unit tests pass, provided you don't run them on the BSD PLCs... this is new to me and something I'll have to resolve as part of the TwinCAT CI project. I'd appreciate if I could get 1 sanity check on this. The diff is pretty straightforward and doesn't require a full understanding of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverse IN and OUT indices for the example state FBs to match the enum, because if the order is wrong then IN sends us to OUT and vice versa.
See https://github.com/pcdshub/lcls-twincat-motion/blob/master/lcls-twincat-motion/Library/DUTs/E_EpicsInOut.TcDUT
Motivation and Context
closes #208
How Has This Been Tested?
Fixes the remaining issue in pcdshub/lcls-plc-kfe-rix-motion#61
Where Has This Been Documented?
only here
Pre-merge checklist
Always Newestversion (Library, *)pre-commitor ranpre-commit run --all-files