Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FB_MotionPneumaticActuator to include a flow meter #220

Closed
wants to merge 2 commits into from

Conversation

nrwslac
Copy link
Contributor

@nrwslac nrwslac commented Aug 16, 2024

Description

-Adds FB_FDQ_FlowMeter to FB_MotionPneumaticActuator

Motivation and Context

ST4K4 in TMO gets a flow meter.

How Has This Been Tested?

Running on TMO motion, on local copy of common components.

Where Has This Been Documented?

Pre-merge checklist

  • Code works interactively
  • Test suite passes locally
  • Code contains descriptive comments
  • Libraries are set to Always Newest version (Library, *)
  • Committed with pre-commit or ran pre-commit run --all-files

@nrwslac nrwslac requested a review from NSLentz August 16, 2024 21:11
@ZLLentz
Copy link
Member

ZLLentz commented Aug 16, 2024

You should note that this FB is for general pneumatic motion, not just for the TMO stopper, though it seems like this has only been used for stoppers in practice:
https://github.com/search?q=org%3Apcdshub%20FB_MotionPneumaticActuator&type=code
Do all the cases in the above search also have flow meters added? (ST3K2, ST5K4). Are there any consequences to having the extra PVs, code, and link points available for instances without flow meters?

@nrwslac
Copy link
Contributor Author

nrwslac commented Aug 20, 2024

FB_MotionPneumaticActuator

I think this is a good point. Not all PneumaticActuators will use an FDQ Flow meter. I am going to close this and add an FDQ flow meter to ST4K4's program.

@nrwslac
Copy link
Contributor Author

nrwslac commented Aug 20, 2024

On review, not all actuators utilizing FB_MotionPneumaticActuator will use an FDQ flow meter.

@nrwslac nrwslac closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants