Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Added Dont Strave Together Modded Egg #2657

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

KenRen98
Copy link
Contributor

Description

This separate egg is meant to fix a bug caused by original DST egg, the server in co-process wont start if mod added. This egg uses Superivisord to manage multiple processes, which is recommended by Docker official website.

However, there is an imperfection in this egg implementation, due to the bad design of the server software. It wont take any linux standard signal for exiting, only “c_shutdown()”. I have tried many ways to implement a shutdown method to gracefully shutdown both shards of the game, but it seemed the tries are waste of time and might requrie more package to be added. Thus I made a warnning in stead to alert the user to manually shutdown the servers, anyway its a modded server, currently no better way to solve it. But its definitely better to have a broken server-stop, rather than a broken server-start which causes confusion to the user.

( I literally have spent many month to figure out why the cave shard wont start when certain mods added )

Checklist for all submissions

  • [ x ] Have you followed the guidelines in our Contributing document?
  • [ x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [ x ] Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?: will delete this fork after and re fork

New egg Submissions

  1. [ x ] Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • [ x ] Did you PR the necessary changes to make it work?
  3. [ x ] Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. [ x ] Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. [ x ] You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. [ x ] The egg was exported from the panel

"ghcr.io\/parkervcp\/games:source": "ghcr.io\/parkervcp\/games:source"
},
"file_denylist": [],
"startup": "supervisord -c .\/Supervisord\/supervisord.conf & sleep 1 && cat Warnning.txt & sleep 5 && supervisorctl -c .\/Supervisord\/supervisord.conf",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not allowed. As this way the startup is user editable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any better ideas or solution? well, all Im asking is to get modded server to work properly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not allowed. As this way the startup is user editable.

Can I bulid this into the source image for blocking user editing it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not allowed. As this way the startup is user editable.

Can I bulid this into the source image for blocking user editing it.

Then that would need to be a custom image added to the game registrar

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants