Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

[Infrared] Addition of Infrared to Minecraft Proxy #2729

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shadowner
Copy link

@Shadowner Shadowner commented Feb 6, 2024

Description

Added Infrared Egg to the master branch

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

"description": "The basic installation on infrared with two server configurable via environment variables.",
"features": null,
"docker_images": {
"shadowner\/infrared-egg:latest": "shadowner\/infrared-egg:latest"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if you PR an image to my repo. Why can't this be downloaded in the install script and ran from the home dir?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to the yolks repo ?
I will do it but no tonight sadly, it's in the Todo.md

I use my action on my repo to always fetch the latest infrared release, but I will look more into doing this step in the installation scripts, I had just no clue about how the installation script worked before finding this repo

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it uses github for releases you can use the git script - https://github.com/parkervcp/eggs/blob/master/scripts/github_release_grabber.sh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants