177 only show transfers for connected account #228
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Marcel Ebert <[email protected]>
Co-authored-by: Marcel Ebert <[email protected]>
…dy work like this)
There was a problem hiding this comment.
The code to solve the original issue ticket looks good now.
But the changes for the redeem dialog are wrong. If it timed out and is still pending, then we cannot just say it's cancelled. Because it's not. The user now can take actions for retrying or reimbursing. Instead it should show the following dialog, that I took from the figma.
Thus, I would like these changes to be removed, we should create a follow-up ticket to show proper pending redeem dialogs @prayagd.
Oh, my bad, the status for timedout Back to Stellar transactions is 'Failed', I fixed it, and now it shows the correct dialog (at least according to the old designs). We still need a follow up ticket to implement the buttons and expected behavior, thanks for bringing that up. |
…sfers-for-connected-account # Conflicts: # src/pages/bridge/TransferDialog.tsx
|
@ebma @gonzamontiel Yes there would be tickets for updating the dailog boxes. |
There was a problem hiding this comment.
Maybe showing a message that you have to connect to a wallet account first in order to see transfers, and a message that tells you you don't have any transfers so far (once connected to an account) would make sense @prayagd.
But this is not mentioned in the issue ticket, so the implemented changes LGTM
Closes #177