-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/numericinput edge cases #561
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels very nice, great job.
However, there are cases where the paste event does not behave as expected, namely if I want to paste text within the current text, it will be pasted to the end.
Example:
- input field value is "123"
- my clipboard has the content "4"
- cursor is at the beginning of the input field
- I paste
Expected outcome: 4123 (and cursor between the 4 and 1)
Actual outcome: 1234 (and cursor at the end)
This works correctly on Uniswap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfection 😍.
expected: ignore the input as there is already one "." in the input field further to the left
actual: input changes to "0.2"
expected: either ignore the input as there is already a "." in the input field further to the right or replace input to "1.234"
actual" input changes to "1.2"