Nabla page refresh required after currency swap #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@ebma @prayagd @TorstenStueber Ready for review |
prayagd
approved these changes
Oct 22, 2024
|
@ebma Do you approve ✅? |
ebma
approved these changes
Oct 23, 2024
Sharqiewicz
deleted the
531-nabla-page-refresh-required-after-currency-swap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦈 🟢 PR
After swapping one currency to another on the platform, users must refresh the page to initiate another swap. If they attempt a second swap without refreshing, they encounter the following error: "Transaction failed."
Issue: Token Approval is not reset after successful swap.
Solution: Implement approval query invalidation after successful swap.