Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from preact to react #608

Merged
merged 16 commits into from
Oct 31, 2024
Merged

Conversation

Sharqiewicz
Copy link
Collaborator

@Sharqiewicz Sharqiewicz commented Oct 28, 2024

With all the packages in the portal updated in the last 2 weeks, the migration was really straightforward.

What have I done?

  1. Replace the Preact-related packages with React and React-dom
  2. Remove all properties specific to Preact
  3. Migrate event system to React synthetic event system
  4. Remove deprecated babel configuration for tests in the project
  5. Remove all outdated and unused files and configurations

to do:

  • test all the functionalities (99%)
  • update readme
  • review all todo (in the code)

tested:

Staking

  • stake
  • unstake
  • unlock
  • rewards update
  • rewards claim

Forex AMM

  • Swap
  • Swap pools Deposit/Withdraw
  • Backstop pools Deposit/Withdraw

Spacewalk

  • Bridge
  • Transactions

Wallet connection

  • Connect
  • Disconnect

@Sharqiewicz Sharqiewicz linked an issue Oct 28, 2024 that may be closed by this pull request
3 tasks
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 41ca974
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/6723efc289297400088bb1a1
😎 Deploy Preview https://deploy-preview-608--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sharqiewicz Sharqiewicz changed the title 596 migrate from preact to react (wip) Migrate from preact to react Oct 28, 2024
@Sharqiewicz
Copy link
Collaborator Author

@ebma @TorstenStueber The migration is ready for review ✅

Copy link
Member

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, so many small improvements! Thanks.

Only requested change is to remove the extra comma in the JSX code in the main app file, see comment.

src/components/Layout/Nav/NavItem/index.tsx Show resolved Hide resolved
src/main.tsx Outdated Show resolved Hide resolved
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, thanks a lot for taking the time and doing this refactoring @Sharqiewicz 🙏 Nothing to add to @TorstenStueber's comments.

src/components/Layout/Nav/index.tsx Outdated Show resolved Hide resolved
@Sharqiewicz
Copy link
Collaborator Author

@TorstenStueber @ebma Applied the changes

Copy link
Member

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great!

@Sharqiewicz Sharqiewicz merged commit 934c19e into main Oct 31, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the 596-migrate-from-preact-to-react branch October 31, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Preact to React
3 participants