-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from preact to react #608
Conversation
✅ Deploy Preview for rococo-souffle-a625f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@ebma @TorstenStueber The migration is ready for review ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, so many small improvements! Thanks.
Only requested change is to remove the extra comma in the JSX code in the main app file, see comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, thanks a lot for taking the time and doing this refactoring @Sharqiewicz 🙏 Nothing to add to @TorstenStueber's comments.
@TorstenStueber @ebma Applied the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great!
With all the packages in the portal updated in the last 2 weeks, the migration was really straightforward.
What have I done?
to do:
tested:
Staking
Forex AMM
Spacewalk
Wallet connection