Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use favicon.ico instead of favicon.png #613

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Conversation

Sharqiewicz
Copy link
Collaborator

I don't know why we had two versions of favicon- .png and .ico. I removed the png one and connected .ico as it is the standard

@Sharqiewicz Sharqiewicz requested a review from ebma October 31, 2024 21:09
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit 0cd4b70
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/6723fb34c621be00082a1626
😎 Deploy Preview https://deploy-preview-613--rococo-souffle-a625f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sharqiewicz
Copy link
Collaborator Author

⚠️ After the migration, routing stopped working because the generation of the _redirects file was accidentally removed. Without this file, Netlify couldn’t properly redirect all pages to index.html, causing broken links for client-side routes. This PR includes a hotfix to restore the _redirects file generation, ensuring that Netlify correctly handles routing for that application

@Sharqiewicz Sharqiewicz merged commit e6f4702 into main Oct 31, 2024
5 checks passed
@Sharqiewicz Sharqiewicz deleted the chore/use-favicon-ico branch October 31, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant