Replace tokio's TcpStream with async-std #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y different nodes
b-yap
added a commit
that referenced
this pull request
Jan 26, 2024
* async-std * works, but still in progress * working test withouth extra signals * remove comments and re-add connector drop trait * cleanup * fix the failing test about current slot * fix the failing test about current slot, by connecting to specifically different nodes * update config files * use a different account for testing * fix rustfmt --------- Co-authored-by: Gianfranco <[email protected]>
b-yap
added a commit
that referenced
this pull request
Jan 30, 2024
* adding trace logs to every function call. adding trace logs for the stream's readiness to read data * adding trace logs for ready status * show peer_addr and local_addr * adding std::net::TcpStream * convert std::net::TcpStream to tokio * completely change tokio to std::net * code cleanup, ready for review * remove unnecessary features of tokio * from async to just normal funcs * testing fixes for test not stopping * set timeout for tests to 180 * fixes warnings * Replace tokio's TcpStream with async-std (#481) * async-std * works, but still in progress * working test withouth extra signals * remove comments and re-add connector drop trait * cleanup * fix the failing test about current slot * fix the failing test about current slot, by connecting to specifically different nodes * update config files * use a different account for testing * fix rustfmt --------- Co-authored-by: Gianfranco <[email protected]> --------- Co-authored-by: Gianfranco Tasteri <[email protected]> Co-authored-by: Gianfranco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @bogdanS98, replace
tokio'sTcpStreamwithasync-std's.This is to continue from #475