-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ready: Add accept terms and conditions pop-up to Vortex #105
Ready: Add accept terms and conditions pop-up to Vortex #105
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@pendulum-chain/devs Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pendulum-chain/product can you please provide the link to the terms and conditions for Vortex so this can be merged? |
The terms and conditions are been drafted, will share them once they are ready. |
Till then i would suggest to put this PR on hold |
@prayagd What is the status of the T&C? |
@TorstenStueber @prayagd status is ready. This is the up-to-date T&Cs we've received from legal, which also links to the Privacy Policy wrt Vortex. |
@pendulum-chain/product where do you want to host the T&C? We can't just link to a google doc obviously. |
@ebma we should host on a page like we do on the portal: https://pendulumchain.org/legal/portal-terms-and-conditions |
Okay. But these pages are not owned by the tech team so I assume someone else would take care of putting them there? |
These pages should be maintainted by the maintainer of our website https://vortexfinance.co. We then just link to it. |
@prayagd could you add the page to the VortexFinance website and add the link for tech to link to? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✅ Add
disableNativeEvents
,hideCloseButton
parameters to component✅ Make
onClose
optional in component✅ Add T&C dialog
The url to the T&C has to be changed. (Not url has been provided)