Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready: Add accept terms and conditions pop-up to Vortex #105

Conversation

Sharqiewicz
Copy link
Contributor

✅ Add disableNativeEvents, hideCloseButton parameters to component
✅ Make onClose optional in component
✅ Add T&C dialog

The url to the T&C has to be changed. (Not url has been provided)

@Sharqiewicz Sharqiewicz linked an issue Aug 16, 2024 that may be closed by this pull request
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit 7a917ae
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/672dda72952f7a0008fd37df
😎 Deploy Preview https://deploy-preview-105--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sharqiewicz
Copy link
Contributor Author

@pendulum-chain/devs Ready for review

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is focused by default, let's disable that as otherwise the user would always see it with a border at first.

image

@ebma
Copy link
Member

ebma commented Aug 26, 2024

@pendulum-chain/product can you please provide the link to the terms and conditions for Vortex so this can be merged?

@prayagd
Copy link
Collaborator

prayagd commented Aug 27, 2024

The terms and conditions are been drafted, will share them once they are ready.

@prayagd
Copy link
Collaborator

prayagd commented Aug 27, 2024

Till then i would suggest to put this PR on hold

@ebma ebma added the on-hold label Aug 27, 2024
@ebma ebma changed the title Add accept terms and conditions pop-up to Vortex [On-hold] Add accept terms and conditions pop-up to Vortex Aug 27, 2024
@TorstenStueber
Copy link
Member

@prayagd What is the status of the T&C?

@vadaynujra
Copy link

@TorstenStueber @prayagd status is ready. This is the up-to-date T&Cs we've received from legal, which also links to the Privacy Policy wrt Vortex.

@ebma
Copy link
Member

ebma commented Sep 23, 2024

@pendulum-chain/product where do you want to host the T&C? We can't just link to a google doc obviously.

@vadaynujra
Copy link

@ebma we should host on a page like we do on the portal: https://pendulumchain.org/legal/portal-terms-and-conditions
We can have a similarly structured page e.g. https://www.vortexfinance.co/legal/terms-of-service

@ebma
Copy link
Member

ebma commented Sep 24, 2024

Okay. But these pages are not owned by the tech team so I assume someone else would take care of putting them there?

@TorstenStueber
Copy link
Member

These pages should be maintainted by the maintainer of our website https://vortexfinance.co. We then just link to it.

@vadaynujra
Copy link

@prayagd could you add the page to the VortexFinance website and add the link for tech to link to?

@Sharqiewicz Sharqiewicz changed the title [On-hold] Add accept terms and conditions pop-up to Vortex Ready: Add accept terms and conditions pop-up to Vortex Nov 8, 2024
Copy link
Member

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Sharqiewicz Sharqiewicz merged commit 701692f into polygon-prototype-staging Nov 8, 2024
5 checks passed
@ebma ebma deleted the 103-add-accept-terms-and-conditions-pop-up-to-vortex branch November 8, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add accept terms and conditions pop-up to Vortex
5 participants