140 integrate additional events into google analytics query into the prototype #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sharqiewicz
requested changes
Nov 5, 2024
src/contexts/events.tsx
Outdated
| }); | ||
|
|
||
| previousChainId.current = chainId; | ||
| }, [chainId, previousChainId]); |
There was a problem hiding this comment.
missing dependency: trackEvent
There was a problem hiding this comment.
previousChainId is a useRef and it doesn't change across renders. We don't have to include it in the dependency array
Sharqiewicz
reviewed
Nov 5, 2024
src/contexts/events.tsx
Outdated
|
|
||
| trackEvent({ | ||
| event: 'network_change', | ||
| from_network: previousChainId.current || chainId, |
There was a problem hiding this comment.
We already check if previousChainId.current is undefined, we don't have to || chainId
|
Nice catch @Sharqiewicz, addressed all your comments ✔️ |
gianfra-t
approved these changes
Nov 8, 2024
ebma
deleted the
140-integrate-additional-events-into-google-analytics-query-into-the-prototype
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me some time to figure out how to be able to properly watch the connected network. I noticed that the watchChainId and useChainId both don't fire when switching from or to a non-supported network, ie a network that is not defined in our
wagmiConfig. Since onlypolygonis defined in ourwagmiConfig, it never triggered when switching from any network to polygon.Instead, we are now using the
chainIdcontained in the data of the useAccount hook as it's always updated when the network changes.GA config
New Variables
DLV | from_networkandDLV | to_networkDLV | account_addressNew triggers
DL Event | network_changeEvents
GA4 Event | network_changefrom_network- >{{DLV | from_network }}andto_network->{{DLV | to_network}}DL Event | network_changeGA4 Event | wallet_connectaccount_address->{{DLV | account_address}}Closes #140.