Fix for incorrect assetCode property #280
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Isn't it almost more confusing/error prone now that we have both assetCode and assetCodeRaw?
I propose that we just define assetCode (without padding) in the config and then have a convenience function that derives the Pendulum asset from that. This should be the only place where we need to pad the assetCode with the zero byte (?)
| @@ -49,7 +49,7 @@ exports.subsidizePostSwap = async (req, res) => { | |||
| const assetIssuerHex = `0x${Keypair.fromPublicKey(assetIssuer).rawPublicKey().toString('hex')}`; | |||
| const pendulumCurrencyId = { | |||
| Stellar: { | |||
| AlphaNum4: { code: assetCode.padEnd(4, '\0'), issuer: assetIssuerHex }, | |||
| AlphaNum4: { code: assetCodeRaw.padEnd(4, '\0'), issuer: assetIssuerHex }, | |||
There was a problem hiding this comment.
Isn't the idea that we don't need .padEnd(4, '\0') for assetCodeRaw?
There was a problem hiding this comment.
Yes you're right here, should remove the pad (which should have never been needed, we were already padding on the config).
| @@ -202,7 +202,7 @@ function checkBalancePeriodically( | |||
| try { | |||
| const someBalanceUnits = await getStellarBalanceUnits( | |||
| stellarTargetAccountId, | |||
| outputToken.stellarAsset.code.stringRaw, | |||
There was a problem hiding this comment.
This one was wrong to have been raw in the first place, as it compares with the return of the stellar balance query.
No description provided.