Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for checking outdated data when authorizing via telegram. #3364

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

Graphanton
Copy link
Contributor

Added the ability to set the period for checking outdated data when authorizing via telegram.

@pennersr
Copy link
Owner

pennersr commented Aug 3, 2023

If the time of the telegram server differs from the time of your server...

Wouldn't it be better in this case to actually fix the root cause and make sure your server is running NTP so that the time is not out of sync?

@Graphanton
Copy link
Contributor Author

Yes. I removed it myself. But since Telegram does not strictly regulate the authorization expiration time, I can set my own expiration time, which can be less than the default.

@coveralls
Copy link

coveralls commented Aug 4, 2023

Coverage Status

coverage: 91.328% (-0.2%) from 91.489% when pulling 5a03539 on Graphanton:main into bd61beb on pennersr:main.

@pennersr
Copy link
Owner

pennersr commented Aug 4, 2023

I am okay with adding this functionality, though I think it would be good to reword the documentation. Because "If the time of the telegram server differs from the time of your server..." you need NTP and not this change.

@pennersr
Copy link
Owner

pennersr commented Aug 8, 2023

Thanks for rewording. One last thing, the code is not black formatted causing the build to fail. Can you look into that?

@Graphanton
Copy link
Contributor Author

Ready!

@pennersr pennersr merged commit c733459 into pennersr:main Aug 9, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants