chore(oauth): show an informative log when OAuthError is raise #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pennersr
reviewed
Aug 26, 2023
| % get_token_prefix(self.request_token_url) | ||
| % response.text |
There was a problem hiding this comment.
Issue: I don't think this code works:
>>> (_("test %s %s") % "a" % "b")
Traceback (most recent call last):
File "<console>", line 1, in <module>
TypeError: not enough arguments for format string
This does:
>>> (_("test %s %s") % ("a", "b"))
'test a b'
|
Sorry @pennersr correcting it. Will update it by tomorrow. |
varunsaral
force-pushed
the
informative_errors
branch
from
88e08f7
to
85e2e77
Compare
|
@pennersr, i corrected it. |
|
@pennersr this can be closed after reviewing, i corrected it. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows helpful errors logs when the oauth error is raised