Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(account): Set username only if present #3437

Closed
wants to merge 1 commit into from
Closed

fix(account): Set username only if present #3437

wants to merge 1 commit into from

Conversation

andylolz
Copy link

Refs #2991.

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

@andylolz andylolz changed the title `Only set username if present fix(account): Set username only if present Sep 18, 2023
@pennersr
Copy link
Owner

pennersr commented Oct 8, 2023

This change breaks the test suite.

@andylolz andylolz closed this Oct 8, 2023
@andylolz andylolz deleted the 2991-keep-username branch October 8, 2023 20:39
@andylolz
Copy link
Author

andylolz commented Oct 8, 2023

You’re right – apologies. I won’t be able to spend time on this, so I’ve closed the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andylolz @pennersr