Fix LOGOUT_ON_PASSWORD_CHANGE settings not tested

[SebCorbin]

• Make sure you use semantic commit messages.
  Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
• All Python code must formatted using Black, and clean from pep8 and isort issues.
• JavaScript code should adhere to StandardJS.
• If your changes are significant, please update ChangeLog.rst.
• If your change is substantial, feel free to add yourself to AUTHORS.

Let's test this and find out that it is bugged, then I'll ad a new commit to fix (TDD style)

[pennersr]

Why did you alter this code? AFAIK, Django's AnonymousUser does not have a has_usable_password() method.

[SebCorbin]

AFAIK the comment We end up here when ACCOUNT_LOGOUT_ON_PASSWORD_CHANGE = True is not valid (this is why I'm adding a test), which means :

• if we end up on this view as anonymous, we should be redirected somewhere, LOGIN_URL maybe? And I would suggest doing this in dispatch not after the form is loaded
• we're connected and if we submit this view and successfully change the password:
  • we have LOGOUT_ON_PASSWORD_CHANGE to True and should be logged out
  • LOGOUT_ON_PASSWORD_CHANGE is False and we just redirect to success_url

[pennersr]

These changes are sound. Though, the PasswordSetView() has similar logic, can you give it the same treatment?

[pennersr]

Refactored via 088a4f1