Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibc): use HostInterface for all block height reads in ibc server #4862

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

noot
Copy link
Collaborator

@noot noot commented Sep 17, 2024

Describe your changes

previously, the IBC gRPC server was accessing penumbra-specific state. this updates the server to use HostInterface for all block height reads.

Issue ticket number and link

n/a

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    only affects gRPC server responses

@zbuc
Copy link
Member

zbuc commented Sep 20, 2024

LGTM, thanks!

@zbuc zbuc merged commit dadedc8 into main Sep 20, 2024
13 checks passed
@zbuc zbuc deleted the noot/ibc-query-fix branch September 20, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants