[Meteor 3] Update package to async #149
Open
+58
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grubba27
changed the title
dallman2
approved these changes
Mar 5, 2024
domq
pushed a commit
to epfl-si/wp-veritas
that referenced
this pull request
May 28, 2024
Because `percolate:meteor-synced-cron` uses MongoDB to store its state, we need to merge in [PR 149](percolatestudio/meteor-synced-cron#149) for Meteor 3.0 compatibility, which the maintainer has yet to do at the time of this commit. - Make it so that all the runtime environments (`Makefile` for development; `Dockerfile` for integration and production) apply the [proper technique](https://guide.meteor.com/v1.3/writing-atmosphere-packages.html#overriding-atmosphere-packages) to use the forked package - Enroll the forked package into `.meteor/packages` / `.meteor/versions` with ```shell meteor add percolate:synced-cron ```
domq
pushed a commit
to epfl-si/wp-veritas
that referenced
this pull request
May 29, 2024
Because `percolate:meteor-synced-cron` uses MongoDB to store its state, we need to merge in [PR 149](percolatestudio/meteor-synced-cron#149) for Meteor 3.0 compatibility, which the maintainer has yet to do at the time of this commit. - Make it so that all the runtime environments (`Makefile` for development; `Dockerfile` for integration and production) apply the [proper technique](https://guide.meteor.com/v1.3/writing-atmosphere-packages.html#overriding-atmosphere-packages) to use the forked package - Enroll the forked package into `.meteor/packages` / `.meteor/versions` with ```shell meteor add percolate:synced-cron ```
domq
pushed a commit
to epfl-si/wp-veritas
that referenced
this pull request
May 29, 2024
Because `percolate:meteor-synced-cron` uses MongoDB to store its state, we need to merge in [PR 149](percolatestudio/meteor-synced-cron#149) for Meteor 3.0 compatibility, which the maintainer has yet to do at the time of this commit. - Make it so that all the runtime environments (`Makefile` for development; `Dockerfile` for integration and production) apply the [proper technique](https://guide.meteor.com/v1.3/writing-atmosphere-packages.html#overriding-atmosphere-packages) to use the forked package - Enroll the forked package into `.meteor/packages` / `.meteor/versions` with ```shell meteor add percolate:synced-cron ```
domq
pushed a commit
to epfl-si/wp-veritas
that referenced
this pull request
May 29, 2024
Because `percolate:meteor-synced-cron` uses MongoDB to store its state, we need to merge in [PR 149](percolatestudio/meteor-synced-cron#149) for Meteor 3.0 compatibility, which the maintainer has yet to do at the time of this commit. - Make it so that all the runtime environments (`Makefile` for development; `Dockerfile` for integration and production) apply the [proper technique](https://guide.meteor.com/v1.3/writing-atmosphere-packages.html#overriding-atmosphere-packages) to use the forked package - Enroll the forked package into `.meteor/packages` / `.meteor/versions` with ```shell meteor add percolate:synced-cron ```
klaucode
reviewed
Nov 25, 2024
| @@ -4,7 +4,7 @@ | |||
| "later": { | |||
There was a problem hiding this comment.
this package is deprecated and recommended to change to: @breejs/later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I made some changes to make synced cron work with async. I also translated it to es6, which I will add in a future pr, so that we can discuss changes in smaller steps.
In tiny test, I still get errors with, so it is just a wip pr:
It would be nice, if you have a look, thank you.
Regards
Sebastian