Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVEREST-1612 | print installed version info (server version) in the output of everestctl version #932

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mayankshah1607
Copy link
Member

Examples:

❯ ./bin/everestctl version
2024-12-13T15:31:39.134+0530    DEBUG   Debug logging enabled
ProjectName: everestctl
Version: v0.0.0-a7c8e5f7
FullCommit: a7c8e5f7ec657b0c7026f0c37350562de52b462e
ServerVersion: 0.0.0

❯ ./bin/everestctl version --client-only
2024-12-13T15:31:54.290+0530    DEBUG   Debug logging enabled
ProjectName: everestctl
Version: v0.0.0-a7c8e5f7
FullCommit: a7c8e5f7ec657b0c7026f0c37350562de52b462e

# when not installed
❯ ./bin/everestctl version
2024-12-13T15:33:24.532+0530    DEBUG   Debug logging enabled
ProjectName: everestctl
Version: v0.0.0-a7c8e5f7
FullCommit: a7c8e5f7ec657b0c7026f0c37350562de52b462e
ServerVersion: [NOT INSTALLED]

@mayankshah1607 mayankshah1607 requested a review from a team as a code owner December 13, 2024 10:13
Copy link
Collaborator

@recharte recharte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of the CLI has the v prefix but the server version does not, should we unify them?

@mayankshah1607
Copy link
Member Author

The version of the CLI has the v prefix but the server version does not, should we unify them?

Yeah, makes sense. Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants