Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-637: disable restore on pg-restore deletion #950

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Nov 18, 2024

K8SPG-637 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPG-637

DESCRIPTION

Problem:
If user deletes pg-restore before it fails or succeeds, the operator doesn't remove .spec.backup.restore from pg.

Solution:
Add the percona.com/delete-restore finalizer to the new pg-restore objects, which will remove the required section on deletion of pg-restore if it didn't fail or succeed.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@pooknull pooknull marked this pull request as ready for review November 21, 2024 11:15
@egegunes egegunes added this to the v2.6.0 milestone Nov 25, 2024
egegunes
egegunes previously approved these changes Dec 11, 2024
Copy link
Contributor

@inelpandzic inelpandzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooknull pls check these tests

inelpandzic
inelpandzic previously approved these changes Dec 20, 2024
@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup failure
finalizers passed
init-deploy passed
monitoring passed
one-pod failure
operator-self-healing passed
pitr failure
scaling passed
scheduled-backup failure
self-healing passed
sidecars passed
start-from-backup passed
tablespaces failure
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 19 out of 19

commit: 2ebc2ff
image: perconalab/percona-postgresql-operator:PR-950-2ebc2ffc9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants