K8SPG-487: add global annotations and labels for cr.yaml
#956
+270
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarukovich
reviewed
Dec 2, 2024
| if cr.CompareVersion("2.6.0") >= 0 && cr.Spec.Metadata != nil { | ||
| newCASecret.Annotations = cr.Spec.Metadata.Annotations | ||
| newCASecret.Labels = cr.Spec.Metadata.Labels | ||
| } |
There was a problem hiding this comment.
I didn't catch this place, if we will have different annotations (for example for extentions too), should we put it to secret annotations?
pooknull
requested review from
tplavcic,
ptankov,
jvpasinatto,
eleo007,
hors,
egegunes and
inelpandzic
as code owners
inelpandzic
reviewed
Dec 17, 2024
| @@ -7,6 +7,11 @@ metadata: | |||
| # - percona.com/delete-ssl | |||
| spec: | |||
| crVersion: 2.6.0 | |||
| # metadata: | |||
| # annotations: | |||
| # test-annotation: value | |||
There was a problem hiding this comment.
Do we want to have a test prefix here in the CR? Maybe something like example-annotation or annotation-key. Test feels like a leftover from some testing.
There was a problem hiding this comment.
@pooknull wdyt about this?
|
@pooknull pls check unit tests. |
egegunes
approved these changes
Dec 20, 2024
commit: bbcf318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-487
DESCRIPTION
Problem:
It’s not possible to set
annotations/labelsat a global level for all resources created by operator.Solution:
Add
.spec.metadata.labelsand.spec.metadata.annotationsfields to thecr.yaml.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability