-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPG-619: restart backup jobs on failure #969
base: main
Are you sure you want to change the base?
Conversation
@@ -329,6 +329,8 @@ spec: | |||
# - secret: | |||
# name: cluster1-pgbackrest-secrets | |||
# jobs: | |||
# restartPolicy: OnFailure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change the defaults. We need to add the possibility of configuring it, but we need to have the old behavior by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit: d8b4d5d |
https://perconadev.atlassian.net/browse/K8SPG-619
DESCRIPTION
Problem:
The backup pod currently fails on the first attempt, resulting in the creation of a new pod on failure. This behavior may not be reliable in all Kubernetes environments, due to potential delays in establishing communication with the Kubernetes API.
Cause:
The backup job’s
restartPolicy
is set toNever
, preventing the existing pod from retrying after a failure.Solution:
Add new
.spec.backups.pgbackrest.jobs.restartPolicy
and.spec.backups.pgbackrest.jobs.backoffLimit
fields to thecr.yaml
file so that the user can change it to suit their needs.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability