-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPG-586: Add delete-backups finalizer #989
Open
inelpandzic
wants to merge
11
commits into
main
Choose a base branch
from
K8SPG-586-delete-backups-finalizer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+147
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGFM |
inelpandzic
requested review from
hors,
egegunes and
pooknull
as code owners
December 23, 2024 14:19
inelpandzic
requested review from
tplavcic,
nmarukovich,
ptankov,
jvpasinatto and
eleo007
as code owners
December 23, 2024 18:00
commit: 2c4cfbb |
pooknull
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
In our other operators, we have a delete-backup finalizer under backup CR, meaning we can delete the individual backup.
In PG we can’t do that, the only thing we can delete is all the backups from all the repos or backups for a particular repo.
Solution:
Add a
percona.com/delete-backups
finalizer that will ensure that all backups are removed when the cluster is deleted.When the finalizer is applied, the operator will basically issue
pgbackrest --stanza=db stanza-delete
command that will essentially delete all the backups from all the configured repos. Besides removing all the physical backup files, finalizer will also delete all pg-backup objects since there is no reason to leave them dangling around without physical backups that correspond to them.This is not recommended in production.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability