Default chunk size should be 1 instead of 1000 (PT-1423) #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of 1000 assumes that the table contains rows which can be checksummed quickly. Mostly that's true, in which case the auto-sizer will scale chunk-size up very quickly. But if it isn't true, we need to start at the smallest possible number rather than an arbitrary number.
|
|
|
Hi! Thank you for the pull request. For us to accept it, you need to sign the Contributor License Agreement. Please do it. |
|
I believe I already did. The comment above yours says "All committers have signed the CLA". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't a significant downside to having the chunk-size default to 1, as the chunk resizing algorithm will very quickly scale it up as it can.
There is a big downside to having the chunk-size start higher than 1, in the case of tables whose rows take a long time to chunk.