Exporter tool and minor changes to importer tool #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Component version list needs to be separately maintained and hence models are modified * Importer tool was changed as a result of component version list
den-gts
suggested changes
Feb 13, 2020
| @@ -238,6 +238,12 @@ def __str__(self): | |||
| return "%s" % self.name | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Did you check django admin component version creation page?
| @@ -238,6 +238,12 @@ def __str__(self): | |||
| return "%s" % self.name | |||
|
|
|||
|
|
|||
|
|
|||
| class ComponentVersionListModel(models.Model): | |||
There was a problem hiding this comment.
I suppose Version name. Also without Model part
den-gts
suggested changes
Feb 25, 2020
| @@ -301,8 +307,10 @@ def __str__(self): | |||
| class ComponentVersionModel(models.Model): | |||
| component = models.ForeignKey(ComponentModel, on_delete=models.PROTECT, related_name='component_version') | |||
|
|
|||
| version = models.CharField(max_length=64, verbose_name="Version or build", | |||
| help_text="note: component version instance will be cloned if you change version!") | |||
| version = models.ForeignKey(ComponentVersionListModel, to_field='version', | |||
There was a problem hiding this comment.
I suggest to leave models.CharFiled and move release_date field to ComponentVersion. My opinion ComponentVersionList equal to ComponentVersion. Also we should review meta_updated field: may be it equal to release_time. @perfguru87 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and accept if all well. Below changes -
Exporter tool
ComponentVersionListmodel.`* entry1
python3.6 ./manage.py exporter -o -x export_file.xlsxOptions are:
x - output excel file nameo - overwrite excel file if existsImporter tool
ComponentVersionList