Skip to content

Commit

Permalink
fix(tests): Swapped WebRequest to HttpClient in test data provider.
Browse files Browse the repository at this point in the history
Signed-off-by: Johannes Tegnér <[email protected]>
  • Loading branch information
Johannestegner committed Feb 14, 2022
1 parent f8c87df commit e313d02
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions Personnummer.Tests/DataProvider.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Net;
using System.Net.Http;
using Newtonsoft.Json;

namespace Personnummer.Tests
Expand Down Expand Up @@ -31,13 +30,13 @@ public struct PersonnummerData

public class DataProvider: IEnumerable<object[]>
{
protected static readonly HttpClient webClient = new HttpClient();
protected static List<PersonnummerData> Data { get; }

static DataProvider()
{
WebRequest request = WebRequest.Create("https://raw.githubusercontent.com/personnummer/meta/master/testdata/list.json");
string result = (new StreamReader(request.GetResponse().GetResponseStream())).ReadToEnd();
Data = JsonConvert.DeserializeObject<List<PersonnummerData>>(result);
var response = webClient.GetStringAsync("https://raw.githubusercontent.com/personnummer/meta/master/testdata/list.json").Result;
Data = JsonConvert.DeserializeObject<List<PersonnummerData>>(response);
}

/// <inheritdoc />
Expand Down Expand Up @@ -67,13 +66,13 @@ IEnumerator IEnumerable.GetEnumerator()

public class OrgNumberDataProvider : IEnumerable<object[]>
{
protected static readonly HttpClient webClient = new HttpClient();
protected static List<PersonnummerData> Data { get; }

static OrgNumberDataProvider()
{
WebRequest request = WebRequest.Create("https://raw.githubusercontent.com/personnummer/meta/master/testdata/orgnumber.json");
string result = (new StreamReader(request.GetResponse().GetResponseStream())).ReadToEnd();
Data = JsonConvert.DeserializeObject<List<PersonnummerData>>(result);
var response = webClient.GetStringAsync("https://raw.githubusercontent.com/personnummer/meta/master/testdata/orgnumber.json").Result;
Data = JsonConvert.DeserializeObject<List<PersonnummerData>>(response);
}

/// <inheritdoc />
Expand Down

0 comments on commit e313d02

Please sign in to comment.