Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto correct multiple expectations #74

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Add auto correct multiple expectations #74

merged 8 commits into from
Dec 19, 2023

Conversation

Bhacaz
Copy link
Collaborator

@Bhacaz Bhacaz commented Dec 19, 2023 •
edited
Loading

Fix #59

@Bhacaz Bhacaz marked this pull request as ready for review December 19, 2023 13:05
@Bhacaz Bhacaz requested a review from makesime December 19, 2023 13:05
makesime
makesime approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@makesime makesime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Je vais enfin arrêter de gosser le monde avec mes :aggregate_failures, thanks 🚀

spec/rubocop/cop/rspec/multiple_expectations_spec.rb

expect_offense(<<~RUBY)
describe Foo do
it 'uses expect twice', timecop: true do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien pensé 💡

@Bhacaz Bhacaz merged commit 8564ab6 into main Dec 19, 2023
1 check passed
@Bhacaz Bhacaz deleted the add_auto_correct_multiple_expectations branch December 19, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makesime makesime makesime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultipleExpectations could autocorrect with aggregate_failures: true
2 participants
@Bhacaz @makesime