Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally parse with JSON::PP #36

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Optionally parse with JSON::PP #36

wants to merge 5 commits into from

Conversation

XanC
Copy link

@XanC XanC commented Feb 23, 2018

In upgrading from Debian Wheezy to Debian Stretch, I found that my script that runs WebService::Solr no longer worked: JSON::XS in WebService::Solr::Response always failed to parse the response, even when the response was perfectly valid. I believe this is because my script is multi-threaded, and JSON::XS is not guaranteed thread-safe. JSON::PP works perfectly.

This pull request implements an option to allow WebService::Solr to use JSON::PP. There may be a better way of achieving this.

Thank you for WebService::Solr!

@petdance
Copy link
Owner

Thanks for looking into this. It seems like a reasonable thing to want.

I can't use this PR as-is because there are no tests and no updates to documentation to explain to the user how to use the new functionality.

@XanC
Copy link
Author

XanC commented Feb 23, 2018

Thanks. I've added a documentation line describing the new PP option. Also I created a new PP version of each test that called WebService::Solr->new(), modifying each one to enable the PP option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants