Untar directly in rust #1347
Merged
Untar directly in rust #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not immediately sure if we want to accept this (probably? I'd want to check with the others first), but I know I'd click the merge button on a making-the-process-more-resilient PR. |
workingjubilee
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Talked to @thomcc and he says this means we're compiling in and shipping libbzip2, but that seems fine. Preferable, even.
Good: doesn't require tar and bzip2 cli tools Bad: more dependencies I guess
passcod
force-pushed
the
untar-in-rust
branch
from
4006644
to
62ad8df
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good: doesn't require tar and bzip2 cli tools
Bad: more rust dependencies I guess
This PR also changes the untar process to be a little more resistant to unexpected crashes (or power failures), downloading and unpacking to a staging directory before moving the new sources in place. Happy to split that into its own PR if you want.