Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imply NOT_IN_SAMPLE for GucFlags::NO_SHOW_ALL #1925

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Imply NOT_IN_SAMPLE for GucFlags::NO_SHOW_ALL #1925

merged 3 commits into from
Oct 24, 2024

Commits on Oct 23, 2024

  1. Add test that demonstrates assertion failure when NO_SHOW_ALL guc fla… 

    …g is used
    @Ngalstyan4
    Ngalstyan4 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    04b93a9 View commit details
    Browse the repository at this point in the history

  2. Fix GucFlags::NO_SHOW_ALL definition to adhere pg invariant 

    Postgres requires this as invariant[1] and not following causes an
assertion failure in debug builds.

[1]:
https://github.com/postgres/postgres/blob/dbedc461b4e7a9cb4d6f5777174bdf180edb95fd/src/backend/utils/misc/guc.c#L1506-L1519
    @Ngalstyan4
    Ngalstyan4 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4cbddd2 View commit details
    Browse the repository at this point in the history

  3. Make GucFlags Copy so flags constrols can be factored out when defini… 

    …ng several GUCs
    @Ngalstyan4
    Ngalstyan4 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5192421 View commit details
    Browse the repository at this point in the history