ci build alpine: add workaround for msgpack-c to resolve relative paths #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otegami
force-pushed
the
fix-msgpack-path-during-build-process
branch
from
6282c53
to
2d4bb0c
Compare
The following error happened when building docker images for Alpine Linux. - ref: https://github.com/pgroonga/docker/actions/runs/9554591639/job/26335983002 ``` > [linux/amd64 stage-0 4/4] RUN /build.sh 3.2.0 14.0.2 && rm -f build.sh: 366.6 libtool: error: cannot determine absolute directory name of 'lib' 366.6 make[4]: *** [Makefile:1025: libgroonga.la] Error 1 366.6 make[4]: Leaving directory '/build/groonga-14.0.2/lib' ``` The cause of this error Adding `--prefix=/usr/local` during configuration step, we expected the libdir path like `/user/local/lib`. But the actual path is `/lib` without prefix because this prefix isn't reflected to pkgconfig file. ```console $ cat /usr/lib/pkgconfig/msgpack-c.pc prefix=/usr exec_prefix=/usr libdir=lib includedir=include Name: MessagePack Description: Binary-based efficient object serialization library Version: 6.0.1 Libs: -L${libdir} -lmsgpack-c Cflags: -I${includedir} ``` Solution We re-write the msgpack-c.pc which can handle prefix path as a workaround. This problem has already fixed on upstream. So after new version releasing, we can delete this workaround. - ref: https://github.com/msgpack/msgpack-c/blob/a5c8a2c845ba43100b7cad7f8a8db0c2ce361d1e/CMakeLists.txt#L33-L42
otegami
force-pushed
the
fix-msgpack-path-during-build-process
branch
from
2d4bb0c
to
4f3d125
Compare
otegami
changed the title
|
|
Can we solve this by using CMake? |
|
Sure. I think it's good timing to use CMake because we can test it at this time too, |
|
I'm going to close this issue and then open a new PR for solving this issue using CMake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error happened when building docker images for Alpine Linux.
The cause of this error
Adding
--prefix=/usr/localduring configuration step, we expected thelibdir path like
/user/local/lib. But the actual path is/libwithout prefixbecause this prefix isn't reflected to pkgconfig file.
This is the same problem is this PR: msgpack/msgpack-c#1119
Solution
We re-write the msgpack-c.pc which can handle prefix path as a workaround.
This workaround is referred to this commit: groonga/groonga@8275463.
This problem has already fixed at upstream.
So after new version releasing, we can delete this workaround.
Additionally, I checked the build step passed here.