Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Primitives] Add default=None for list_lookup #1154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Oct 12, 2022

  1. [Primitives] Adds default=None for list_lookup

    Rather than use an explicit default value as the standard pattern, it
    makes more sense to use the final element of the list since we're
    buildling a mux tree anyways.  The existing explicit "default" value
    pattern might still be useful to emulate a certain "else" pattern that's
    different than the last element.
    
    In adding this, I noticed the mux tree was being built forwards, which
    made the generated code a bit convoluted for this default case, so I
    reversed the tree instead to make it look more natural in the generated
    code.
    leonardt committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    0a992a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Add comment

    leonardt committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    7320ea4 View commit details
    Browse the repository at this point in the history