Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReversingLabs reported email triage #196

Merged

Conversation

MislavReversingLabs
Copy link
Contributor

No description provided.

@MislavReversingLabs
Copy link
Contributor Author

@kelby-shelton When can we start working on this PR?

@kelby-shelton
Copy link
Contributor

@kelby-shelton When can we start working on this PR?

I looked at the submission and it appears that the automated checks are not running so I ran them manually. These are the problems that were found:

20241029 13:48:43.896 ERROR Block 'run_query_1' is not named  
20241029 13:48:43.898 ERROR Block 'get_email_1' is not named  
20241029 13:48:43.900 ERROR Block 'detonate_file_1' is not named  
20241029 13:48:43.901 ERROR Block 'get_summary_report_1' is not named  
20241029 13:48:43.903 ERROR Block 'filter_2' is not named  
20241029 13:48:43.907 ERROR Block 'run_query_1' does not have notes  
20241029 13:48:43.908 ERROR Block 'get_email_1' does not have notes  
20241029 13:48:43.909 ERROR Block 'detonate_file_1' does not have notes  
20241029 13:48:43.910 ERROR Block 'get_summary_report_1' does not have notes  
20241029 13:48:43.911 ERROR Block 'filter_2' does not have notes  
20241029 13:48:43.929 ERROR Incorrect asset name in block 'run_query_1'  
20241029 13:48:43.931 ERROR Incorrect asset name in block 'get_email_1'  
20241029 13:48:43.932 ERROR Incorrect asset name in block 'detonate_file_1'  
20241029 13:48:43.934 ERROR Incorrect asset name in block 'get_summary_report_1'

20241029 13:48:43.896 ERROR Block 'run_query_1' is not named
20241029 13:48:43.898 ERROR Block 'get_email_1' is not named
20241029 13:48:43.900 ERROR Block 'detonate_file_1' is not named
20241029 13:48:43.901 ERROR Block 'get_summary_report_1' is not named
20241029 13:48:43.903 ERROR Block 'filter_2' is not named
20241029 13:48:43.907 ERROR Block 'run_query_1' does not have notes
20241029 13:48:43.908 ERROR Block 'get_email_1' does not have notes
20241029 13:48:43.909 ERROR Block 'detonate_file_1' does not have notes
20241029 13:48:43.910 ERROR Block 'get_summary_report_1' does not have notes
20241029 13:48:43.911 ERROR Block 'filter_2' does not have notes
20241029 13:48:43.929 ERROR Incorrect asset name in block 'run_query_1'
20241029 13:48:43.931 ERROR Incorrect asset name in block 'get_email_1'
20241029 13:48:43.932 ERROR Incorrect asset name in block 'detonate_file_1'
20241029 13:48:43.934 ERROR Incorrect asset name in block 'get_summary_report_1'

Copy link
Contributor

@kelby-shelton kelby-shelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix these issues:

  • Playbook description empty
  • Playbook notes empty
  • 5 blocks missing custom names, e.g. get_summary_report_1 should be "get summary report" as a custom name
  • 5 blocks missing notes tooltip

@MislavReversingLabs
Copy link
Contributor Author

We'll fix those errors quickly and cummit the changes.

@MislavReversingLabs
Copy link
Contributor Author

@kelby-shelton I corrected the files. Please have a look.

Copy link
Contributor

@kelby-shelton kelby-shelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kelby-shelton kelby-shelton merged commit fe79780 into phantomcyber:6.3 Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants